Fix Patch Rebuild skipping .deb/.rpm/.AppImage builds#24
Open
JonahBraun wants to merge 1 commit intomasterfrom
Open
Fix Patch Rebuild skipping .deb/.rpm/.AppImage builds#24JonahBraun wants to merge 1 commit intomasterfrom
JonahBraun wants to merge 1 commit intomasterfrom
Conversation
Two compounding bugs caused Patch Rebuilds to produce releases missing Linux package assets (.deb, .rpm, .AppImage). PATCH_REBUILD was not propagated from the check job to the build matrix jobs, and the asset- existence checks for these formats used version-less patterns that matched assets from previous releases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Patch Rebuild skipping .deb/.rpm/.AppImage builds due to missing PATCH_REBUILD propagation and version-less asset checks.
Release 1.108.11148 shipped without any .deb, .rpm, or .AppImage files. The check job correctly detected the patch rebuild and skipped asset checking, but the build matrix jobs ran their own check_tags.sh without PATCH_REBUILD set. Combined with version-less contains checks (e.g. "amd64.deb" matching the previous release's assets), the build jobs falsely concluded the packages already existed and skipped them.
Changes
Test plan